[fix][broker] URL-encode sub-name in Txn pending-ack topic #25727
Merged
shibd merged 1 commit intoapache:masterfrom May 9, 2026
Merged
[fix][broker] URL-encode sub-name in Txn pending-ack topic #25727shibd merged 1 commit intoapache:masterfrom
shibd merged 1 commit intoapache:masterfrom
Conversation
…pport '/' in sub names
Subscription names containing '/' caused TopicName.get() to throw
IllegalArgumentException ("V1 topic names are no longer supported")
when opening the transaction pending-ack store, because the extra
slashes created four path segments instead of three.
Fix: URL-encode the subscription name in
MLPendingAckStore.getTransactionPendingAckStoreSuffix() before
appending it to the topic name. TopicName always Codec.decode()s
the local-name on parse and re-encodes it on output, so there is
no double-encoding. Also remove the pre-emptive Codec.encode() call
in PersistentTopic.unsubscribe() that was added as a workaround.
shibd
added
type/bug
shibd
requested review from
BewareMyPower,
codelipenghui,
lhotari,
merlimat and
poorbarcode
poorbarcode
approved these changes
May 9, 2026
shibd
changed the title
11 tasks
shibd
added a commit
that referenced
this pull request
May 9, 2026
Member
|
does 4.0.x need this fix too? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
When a subscription name contains
/(e.g. a Pulsar Function's fully-qualified name liketenant/namespace/function), opening the transaction pending-ack store fails with:Root cause:
MLPendingAckStore.getTransactionPendingAckStoreSuffix()appends the raw subscription name to the topic name string. When the result is passed toTopicName.get(), the extra/characters produce four path segments, whichTopicNamemisidentifies as a deprecated V1 (cluster-scoped) name and throws synchronously.Changes
MLPendingAckStore.getTransactionPendingAckStoreSuffix(): URL-encode the subscription name withCodec.encode()before appending it.TopicNamealwaysCodec.decode()s the local-name on parse and re-encodes it on output (getPersistenceNamingEncoding()), so there is no double-encoding and the managed-ledger path is correct.PersistentTopic.unsubscribe(): Remove the pre-emptiveCodec.encode()call — encoding is now done centrally ingetTransactionPendingAckStoreSuffix().Verifying this change
All tests passed
Does this pull request potentially affect one of the following parts:
If the box was checked, please highlight the changes